-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated java tests now passes with unique validation #9669
generated java tests now passes with unique validation #9669
Conversation
Checks if a required entity is already created in the createEntity method, adds the creatUpdatedEntity using the UPDATED_ constants and adds the findAll method to TestUtils. Fix jhipster#9666
/** | ||
* Create an entity for this test. | ||
* Create an <% if (fieldStatus === 'UPDATED_') { %>updated<% } %> entity for this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be: Create an <% if (fieldStatus === 'UPDATED_') { %>updated <% } %>entity for this test.
Otherwise, we can have: * Create an entity for this test.
, with 2 spaces between an
and entity
* @param <T> The type of objects to be searched | ||
* @param em The instance of the EntityManager | ||
* @param clss The class type to be searched | ||
* @return A list of all found objects of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A list of all found objects of the
-> A list of all found objects
/** | ||
* Create an entity for this test. | ||
* Create an <% if (fieldStatus === 'UPDATED_') { %>updated<% } %>entity for this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh still missing 1 space: %>updated <%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed directly in your branch
thanks for your fix @Gabrui ! |
Checks if a required entity is already created in the createEntity method,
adds the creatUpdatedEntity using the UPDATED_ constants and
adds the findAll method to TestUtils.
Fix #9666
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed